[FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

Valery Kot valery.kot at gmail.com
Mon Jun 22 15:24:19 EEST 2020


On Mon, Jun 22, 2020 at 12:54 PM Moritz Barsnick <barsnick at gmx.net> wrote:
>
> On Fri, Jun 19, 2020 at 17:15:06 +0200, Valery Kot wrote:
> > -            if ((!i || i == w - 1 || !j || j == h - 1) &&
> > +            if (!(!i || i == w - 1 || !j || j == h - 1) &&
>
> NOT of a logical OR can be inverted, so this *may* be more readable as:
>                if ((i && i != w - 1 && j && j != h - 1) &&
> or even drop the bracket
>                if (i && i != w - 1 && j && j != h - 1 &&
>

Indeed, those three are equivalent. Complex logical conditions can be
written in different ways. I chose mine to minimize change, assuming
that there was just a typo in original algo implementation.


More information about the ffmpeg-devel mailing list