[FFmpeg-devel] [PATCH 3/4] avutil/timecode: add function av_timecode_get_smpte_by_tc_string()

Nicolas George george at nsup.org
Sat Jun 20 15:51:59 EEST 2020


lance.lmwang at gmail.com (12020-06-20):
> av_timecode_init_from_string() will initialize the AVTimecode structure,
> it'll do more functions, if don't duplicate the code. I can do like below:
> 1. use av_timecode_init_from_string() to init the tc
> 2. use av_timecode_get_smpte_from_framenum() to get the smpte binary
> 
> do you think it's OK?

Yes, I think it is the correct way of doing it: using existing functions
instead of copying their code.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200620/849e0a00/attachment.sig>


More information about the ffmpeg-devel mailing list