[FFmpeg-devel] [PATCH 3/4] avutil/timecode: add function av_timecode_get_smpte_by_tc_string()

[lance.lmwang at gmail.com]

On Sat, Jun 20, 2020 at 02:28:39PM +0200, Nicolas George wrote:
> lance.lmwang at gmail.com (12020-06-20):
> > No, different function, if I can use it, then I'll use it.
> 
> Duplicating parsing code is a big no.
av_timecode_init_from_string() will initialize the AVTimecode structure,
it'll do more functions, if don't duplicate the code. I can do like below:
1. use av_timecode_init_from_string() to init the tc
2. use av_timecode_get_smpte_from_framenum() to get the smpte binary

do you think it's OK?


> 
> > do you have a broken string for my condition, I'm glad to test and fix it?
> 
> Any valid string with anything appended at the end.

OK, I'll try to test it.

> 
> Regards,
> 
> -- 
>   Nicolas George



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


-- 
Thanks,
Limin Wang