[FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

[mypopy at gmail.com]

On Fri, Jul 31, 2020 at 3:47 AM Alexander Strasser <eclipse7 at gmx.net> wrote:
>
> On 2020-07-30 21:18 +0800, mypopy at gmail.com wrote:
> >
> > After repeated thinking， I can accept this solution, thx
>
> Just to avoid confusion. You accept this
>
> > > > > avctx->bit_rate += (s->bit_rate - avctx->bit_rate) / s->frame_number;
>
This part  for potential overflow :)
> or this
>
> > > If you are aiming for improving accuracy, I guess going for
> > > implementing the sum of bitrates is the most straight forward
> > > way. It wouldn't need floating point arithmetic and overflow
> > > wouldn't be much of a concern if I'm not mistaken.
>
> solution?
>
>
> Thanks,
>   Alexander
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



-- 
=======================================
Jun zhao/赵军
+++++++++++++++++++++++++++++++++++++++