[FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

Alexander Strasser eclipse7 at gmx.net
Thu Jul 30 22:47:13 EEST 2020


On 2020-07-30 21:18 +0800, mypopy at gmail.com wrote:
>
> After repeated thinkingļ¼Œ I can accept this solution, thx

Just to avoid confusion. You accept this

> > > > avctx->bit_rate += (s->bit_rate - avctx->bit_rate) / s->frame_number;

or this

> > If you are aiming for improving accuracy, I guess going for
> > implementing the sum of bitrates is the most straight forward
> > way. It wouldn't need floating point arithmetic and overflow
> > wouldn't be much of a concern if I'm not mistaken.

solution?


Thanks,
  Alexander


More information about the ffmpeg-devel mailing list