[FFmpeg-devel] [PATCH] x86/yuv2rgb: fix crashes when storing data on unaligned buffers

Carl Eugen Hoyos ceffmpeg at gmail.com
Tue Jul 14 19:55:22 EEST 2020


Am Mo., 13. Juli 2020 um 15:19 Uhr schrieb James Almer <jamrial at gmail.com>:
>
> On 7/13/2020 4:02 AM, Carl Eugen Hoyos wrote:
> >
> >
> >> Am 13.07.2020 um 02:33 schrieb James Almer <jamrial at gmail.com>:
> >>
> >> Regression since fc6a5883d6af8cae0e96af84dda0ad74b360a084 on SSSE3 enabled
> >> CPUs.
> >
> > FFmpeg does not require aligned output buffers on x86_64?
>
> There's no alignment requirement mentioned anywhere in swscale.h, which
> explains why every other asm function also uses unaligned mov
> instructions when handling src and dst buffers.

Thank you both for the explanation, I misremembered.

> >> Fixes ticket #8747
> >
> > Another issue is described in this ticket that implies an overwrite: Can you reproduce?
>
> No, I haven't tried that one under valgrind.

Given that I was unable to produce unaligned buffers for above issue,
this part of the report looked more important to me.

Carl Eugen


More information about the ffmpeg-devel mailing list