[FFmpeg-devel] [PATCH] x86/yuv2rgb: fix crashes when storing data on unaligned buffers

Michael Niedermayer michael at niedermayer.cc
Mon Jul 13 21:58:18 EEST 2020


On Mon, Jul 13, 2020 at 10:19:07AM -0300, James Almer wrote:
> On 7/13/2020 4:02 AM, Carl Eugen Hoyos wrote:
> > 
> > 
> >> Am 13.07.2020 um 02:33 schrieb James Almer <jamrial at gmail.com>:
> >>
> >> Regression since fc6a5883d6af8cae0e96af84dda0ad74b360a084 on SSSE3 enabled
> >> CPUs.
> > 
> > FFmpeg does not require aligned output buffers on x86_64?
> 
> There's no alignment requirement mentioned anywhere in swscale.h, which
> explains why every other asm function also uses unaligned mov
> instructions when handling src and dst buffers.

swscale will print a warning though if its provided with unaligned
buffers or strides
So i would assume that most library users attempt to supply it with
aligned buffers.
Thats something new optimized code could take advantage of

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200713/44f1d0e0/attachment.sig>


More information about the ffmpeg-devel mailing list