[FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_gblur: add x86 SIMD optimizations

[Song, Ruiling]

> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Reimar D?ffinger
> Sent: Wednesday, June 12, 2019 1:51 PM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_gblur: add x86
> SIMD optimizations
> 
> 
> 
> On 12.06.2019, at 03:00, Ruiling Song <git at videolan.org> wrote:
> 
> > ffmpeg | branch: master | Ruiling Song <ruiling.song at intel.com> | Wed
> May 15 17:54:10 2019 +0800| [83f9da77684e7ea0d8e9f9712ec716424140043a]
> | committer: Ruiling Song
> >
> > avfilter/vf_gblur: add x86 SIMD optimizations
> >
> > The horizontal pass get ~2x performance with the patch
> > under single thread.
> >
> > Tested overall performance using the command(avx2 enabled):
> > ./ffmpeg -i 1080p.mp4 -vf gblur -f null /dev/null
> > ./ffmpeg -i 1080p.mp4 -vf gblur=threads=1 -f null /dev/null
> > For single thread, the fps improves from 43 to 60, about 40%.
> > For multi-thread, the fps improves from 110 to 130, about 20%.
> >
> > Signed-off-by: Ruiling Song <ruiling.song at intel.com>
> >
> >>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=83f9da77684e7e
> a0d8e9f9712ec716424140043a
> > ---
> >
> > libavfilter/gblur.h             |  55 ++++++++++++
> > libavfilter/vf_gblur.c          |  71 +++++++--------
> > libavfilter/x86/Makefile        |   2 +
> > libavfilter/x86/vf_gblur.asm    | 185
> ++++++++++++++++++++++++++++++++++++++++
> > libavfilter/x86/vf_gblur_init.c |  36 ++++++++
> > 5 files changed, 310 insertions(+), 39 deletions(-)
> >
> > diff --git a/libavfilter/gblur.h b/libavfilter/gblur.h
> > new file mode 100644
> > index 0000000000..87129801de
> > --- /dev/null
> > +++ b/libavfilter/gblur.h
> > @@ -0,0 +1,55 @@
> > +/*
> > + * Copyright (c) 2011 Pascal Getreuer
> > + * Copyright (c) 2016 Paul B Mahol
> > + *
> > + * Redistribution and use in source and binary forms, with or without
> modification,
> > + * are permitted provided that the following conditions are met:
> > + *
> > + *  * Redistributions of source code must retain the above copyright
> > + *    notice, this list of conditions and the following disclaimer.
> > + *  * Redistributions in binary form must reproduce the above
> > + *    copyright notice, this list of conditions and the following
> > + *    disclaimer in the documentation and/or other materials provided
> > + *    with the distribution.
> 
> Where does this license come from?
The license is from vf_gblur.c, because the code was copied from there.
If I read correctly, this is "Simplified BSD License".

> Is that even GPL-compatible?
> I mean how is someone compiling ffmpeg even supposed to know
> they have to put this license text in their documentation?


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".