[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: log skipped initial non-keyframes

[Moritz Barsnick]

On Fri, Jun 07, 2019 at 22:35:03 +0200, Stephan Hilb wrote:
> > Incorrect indentation.
>
> It's actually the same indentation as in other places in the same file,
> what would be the correct way then?

Sorry, my mind went flaky, you're corrent.

> > I suggest this message should be at INFO level, but appear only once.
>
> I'm fine with INFO level. Repeated messages get supressed anyways, does
> that suffice?

If it only appears once, then fine. I couldn't test (see below), so
couldn't see whether this comes for every skipped frame.

> > I believe ffprobe also suffers from such files and never displays
> > anyhing with -show_frames. In fact, does ffprobe perhaps always begin
> > from, or at least wait for, the first keyframe?
>
> Cannot really comment on that. For me it happens when stream copying
> from v4l2, since the keyframe flag is not being set there, Probing
> works just fine.

Okay, I may have a look at ffprobe myself.

Thanks for the v4l2 hint, I can use that to produce a sample.

Moritz