[FFmpeg-devel] [PATCH V8 2/2] avcodec/libx264: add support for ROI-based encoding

Carl Eugen Hoyos ceffmpeg at gmail.com
Thu Jan 10 19:19:13 EET 2019

2019-01-10 9:54 GMT+01:00, Guo, Yejun <yejun.guo at intel.com>:

> +                        roi = (AVRegionOfInterest*)((char*)roi +
> roi->self_size);

Isn't this roi++?
If yes, please change this.

I also wonder if the wording (elsewhere) of "returns EINVAL
if size is zero" is correct: Shouldn't it be "size must be >0"
or similar? A struct can hardly return an error, no?

Sorry for the late comment, Carl Eugen

More information about the ffmpeg-devel mailing list