[FFmpeg-devel] [PATCH V5 1/2] avutil: add ROI (Region Of Interest) data struct and bump version

Michael Niedermayer michael at niedermayer.cc
Fri Jan 4 19:23:19 EET 2019

On Fri, Jan 04, 2019 at 04:26:51PM +0000, Derek Buitenhuis wrote:
> On 04/01/2019 14:15, Nicolas George wrote:
> > Rostislav Pehlivanov (12019-01-04):
> >> Hence an AVRational is appropriate as you can have fractions between 0 and
> >> 1, the encoder can adjust it and it'll be agnostic.
> > 
> > Yes, AVRational is fine. Producing warnings for an unexpected
> > denominator would be a bad idea.
> Agree... I don't really understand how such a requirement could even be feasibly
> used in an agnostic way... you'd need some function to return the quantizer
> offset range for any given encoder, or you risk it just failing, or having a
> huge load of code in any user application (filter, mpv, whatever) that has
> to special case every single encoder. And also a flag saying it can consume
> this data at all.

> As a side note, I'd like to point out, that this is well into bikeshed territory;
> Yejun sent v1 of this set a month ago and every revision has different people wanting
> different things, after being silent for weeks. I can imagine it's a bit frustrating.

i would suggest that if a disagreement on types remain that people move
the discussion to a thread dedicated to the type of what the disagrement is
abouzt like width/height.
Its not specific to this patch. This should avoid the frustration, as
only once the disagreement is resolved would then someone reply here with
what type it should be.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190104/c2371507/attachment.sig>

More information about the ffmpeg-devel mailing list