[FFmpeg-devel] [PATCH V5 1/2] avutil: add ROI (Region Of Interest) data struct and bump version

Derek Buitenhuis derek.buitenhuis at gmail.com
Fri Jan 4 18:26:51 EET 2019

On 04/01/2019 14:15, Nicolas George wrote:
> Rostislav Pehlivanov (12019-01-04):
>> Hence an AVRational is appropriate as you can have fractions between 0 and
>> 1, the encoder can adjust it and it'll be agnostic.
> Yes, AVRational is fine. Producing warnings for an unexpected
> denominator would be a bad idea.

Agree... I don't really understand how such a requirement could even be feasibly
used in an agnostic way... you'd need some function to return the quantizer
offset range for any given encoder, or you risk it just failing, or having a
huge load of code in any user application (filter, mpv, whatever) that has
to special case every single encoder. And also a flag saying it can consume
this data at all.

As a side note, I'd like to point out, that this is well into bikeshed territory;
Yejun sent v1 of this set a month ago and every revision has different people wanting
different things, after being silent for weeks. I can imagine it's a bit frustrating.

- Derek

More information about the ffmpeg-devel mailing list