[FFmpeg-devel] [PATCH V4] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

[Guo, Yejun]

> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of
> Moritz Barsnick
> Sent: Thursday, August 22, 2019 3:31 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH V4] avcodec/libvpxenc: add ROI-based
> encoding support for VP8/VP9 support
> 
> On Thu, Aug 22, 2019 at 08:56:28 +0800, Guo, Yejun wrote:
> > +    /* This list must be iterated in reverse, so for the case that
> > +     * two regions overlapping, the more important area takes effect.
> 
> Nit: "overlap" or "are overlapping".

thanks, will change.

> 
> > +#ifdef VPX_CTRL_VP9E_SET_ROI_MAP
> [...]
> > +#endif
> > +
> > +    av_assert0(!roi_supported);
> > +    if (!ctx->roi_warned) {
> > +        ctx->roi_warned = 1;
> > +        av_log(avctx, AV_LOG_WARNING, "ROI is not supported, please
> upgrade libvpx to version >= 1.8.1\n");
> > +    }
> 
> Nit: upgrading alone won't help, you'll actually need to rebuild. ;-)
> (I'm saying it may be confusing to the end user, if they ever encounter
> it.)

yes, it will confuse end user. For version 1.8.0 to 1.8.1, there is no need to rebuild, but for others, the rebuild is needed.

I'll add message like: and you might need to build ffmpeg again.

> 
> Cheers,
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".