[FFmpeg-devel] [PATCH V4] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

[Moritz Barsnick]

On Thu, Aug 22, 2019 at 08:56:28 +0800, Guo, Yejun wrote:
> +    /* This list must be iterated in reverse, so for the case that
> +     * two regions overlapping, the more important area takes effect.

Nit: "overlap" or "are overlapping".

> +#ifdef VPX_CTRL_VP9E_SET_ROI_MAP
[...]
> +#endif
> +
> +    av_assert0(!roi_supported);
> +    if (!ctx->roi_warned) {
> +        ctx->roi_warned = 1;
> +        av_log(avctx, AV_LOG_WARNING, "ROI is not supported, please upgrade libvpx to version >= 1.8.1\n");
> +    }

Nit: upgrading alone won't help, you'll actually need to rebuild. ;-)
(I'm saying it may be confusing to the end user, if they ever encounter
it.)

Cheers,
Moritz