[FFmpeg-devel] [PATCH 3/6] avcodec/pngdec: Optimize has_trns code

Michael Niedermayer michael at niedermayer.cc
Sun Aug 18 11:31:46 EEST 2019


On Sun, Aug 18, 2019 at 08:49:06AM +0200, Reimar Döffinger wrote:
> On 18.08.2019, at 01:28, Michael Niedermayer <michael at niedermayer.cc> wrote:
> 
> > 30M cycles -> 5M cycles
> 
> I see nothing wrong with it, but:
> You could save reviewers a lot of time if you gave them a hint of what the change
> contains instead of them having to reverse-engineer.
> In this case for example something like
> "add inner loop specialisations for 2 bpp and 4 bpp"

added


> 
> > 
> > @@ -1363,19 +1364,38 @@ exit_loop:
> >         unsigned x, y;
> > 
> >         av_assert0(s->bit_depth > 1);
> > -
> 
> Cosmetic?

removed and reposted 

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190818/431ddc4f/attachment.sig>


More information about the ffmpeg-devel mailing list