[FFmpeg-devel] [PATCH 3/6] avcodec/pngdec: Optimize has_trns code

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Aug 18 09:49:06 EEST 2019


On 18.08.2019, at 01:28, Michael Niedermayer <michael at niedermayer.cc> wrote:

> 30M cycles -> 5M cycles

I see nothing wrong with it, but:
You could save reviewers a lot of time if you gave them a hint of what the change
contains instead of them having to reverse-engineer.
In this case for example something like
"add inner loop specialisations for 2 bpp and 4 bpp"

> 
> @@ -1363,19 +1364,38 @@ exit_loop:
>         unsigned x, y;
> 
>         av_assert0(s->bit_depth > 1);
> -

Cosmetic?


More information about the ffmpeg-devel mailing list