[FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

[Michael Niedermayer]

On Sun, Aug 11, 2019 at 08:30:51PM +0200, Reimar Döffinger wrote:
> On 08.08.2019, at 10:36, Michael Niedermayer <michael at niedermayer.cc> wrote:
> 
> > This provides an alternative to retry counters.
> > Useful if there is no reasonable maximum number of iterations and
> > no ordering that naturally avoids loops.
> 
> Going by the old principle of "an API is not tested until it has at least 3 users"
> might it make sense to delay this until we've found and tested it in a few use-cases?
> Depending on how much hurry there is to get the bug-fix in.

> I assume there is also an actual bug-fix patch somewhere, maybe we should have that
> in the same patch series to make it easier to review the actual usage?

sure will repost this eventually with 3+ bugfixes.
But wont search for such bugs ATM as ive too many other things to do
so it might take a bit of time before i do


> 
> > diff --git a/doc/APIchanges b/doc/APIchanges
> > index 6603a8229e..eee4c30ec5 100644
> > --- a/doc/APIchanges
> > +++ b/doc/APIchanges
> > @@ -15,6 +15,9 @@ libavutil:     2017-10-21
> > 
> > API changes, most recent first:
> > 
> > +2019-XX-XX - XXXXXXXXXX - lavu 56.XX.XXX - loop_detector.h
> > +  Add loop_detector.h, av_is_loop(), AVSimpleLoopDetector
> 
> Does is mean it is a public/installed header?

that was intended, but it can of course be trivially be kept local if people
prefer when i repost with 3+ dependant fixes 


> I'd prefer to keep new APIs internal until they are really proven in use if there is no immediate pressure.

[...]

thx
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190812/5570cb92/attachment.sig>