[FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

[Reimar Döffinger]

On 08.08.2019, at 10:36, Michael Niedermayer <michael at niedermayer.cc> wrote:

> This provides an alternative to retry counters.
> Useful if there is no reasonable maximum number of iterations and
> no ordering that naturally avoids loops.

Going by the old principle of "an API is not tested until it has at least 3 users"
might it make sense to delay this until we've found and tested it in a few use-cases?
Depending on how much hurry there is to get the bug-fix in.
I assume there is also an actual bug-fix patch somewhere, maybe we should have that
in the same patch series to make it easier to review the actual usage?

> diff --git a/doc/APIchanges b/doc/APIchanges
> index 6603a8229e..eee4c30ec5 100644
> --- a/doc/APIchanges
> +++ b/doc/APIchanges
> @@ -15,6 +15,9 @@ libavutil:     2017-10-21
> 
> API changes, most recent first:
> 
> +2019-XX-XX - XXXXXXXXXX - lavu 56.XX.XXX - loop_detector.h
> +  Add loop_detector.h, av_is_loop(), AVSimpleLoopDetector

Does is mean it is a public/installed header?
I'd prefer to keep new APIs internal until they are really proven in use if there is no immediate pressure.