[FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

Nicolas George george at nsup.org
Sat Aug 10 18:01:49 EEST 2019


Marton Balint (12019-08-08):
> Current 4k limit is definitely causing errors, the users are not aware of
> it, because it is not intuitive.
> 
> I don't see why increasing the limit to 2 GB which is something that we will
> hardly ever hit is worse than current status which causes actual issues.
> 
> Are you against increasing the limit?
> 
> Do you want to increase the limit to UINT_MAX (the AVBprint implementation
> limit) instead of INT_MAX?
> 
> Or do you have some other suggestion?

Another possibility would be to use AV_BPRINT_SIZE_UNLIMITED (thus
extending when AVBPrint is extended) but return FFMIN(actual_size,
INT_MAX).

But in the end, I just said that it felt wrong to have an arbitrary
limit just because of a return value type. I do not oppose any solution.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190810/4f89f64e/attachment.sig>


More information about the ffmpeg-devel mailing list