[FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

Marton Balint cus at passwd.hu
Thu Aug 8 18:44:37 EEST 2019



On Thu, 8 Aug 2019, Nicolas George wrote:

> Marton Balint (12019-08-07):
>> The function returns an int so it can't signal writing longer strings that
>> that.
>
> Yet, replacing an arbitrary limit by another arbitrary limit, however
> high, seems very wrong.

Current 4k limit is definitely causing errors, the users are not aware of 
it, because it is not intuitive.

I don't see why increasing the limit to 2 GB which is something that we 
will hardly ever hit is worse than current status which causes actual 
issues.

Are you against increasing the limit?

Do you want to increase the limit to UINT_MAX (the AVBprint 
implementation limit) instead of INT_MAX?

Or do you have some other suggestion?

Thanks,
Marton


More information about the ffmpeg-devel mailing list