[FFmpeg-devel] [PATCH] swscale: Introduce a helper to identify semi-planar formats

[Philip Langdale]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sat, 3 Mar 2018 23:21:51 +0100
Michael Niedermayer <michael at niedermayer.cc> wrote:

> On Fri, Mar 02, 2018 at 03:40:39PM -0800, Philip Langdale wrote:
> > This cleans up the ever-more-unreadable list of semi-planar
> > exclusions for selecting the planar copy wrapper.
> > ---
> >  libswscale/swscale_internal.h | 7 +++++++
> >  libswscale/swscale_unscaled.c | 7 +------
> >  2 files changed, 8 insertions(+), 6 deletions(-)
> > 
> > diff --git a/libswscale/swscale_internal.h
> > b/libswscale/swscale_internal.h index 0f51df95d7..d3d9da9a34 100644
> > --- a/libswscale/swscale_internal.h
> > +++ b/libswscale/swscale_internal.h
> > @@ -676,6 +676,13 @@ static av_always_inline int isPlanarYUV(enum
> > AVPixelFormat pix_fmt) return ((desc->flags &
> > AV_PIX_FMT_FLAG_PLANAR) && isYUV(pix_fmt)); }
> >  
> > +static av_always_inline int isSemiPlanarYUV(enum AVPixelFormat
> > pix_fmt)  
> 
> please add a comment unambigously defining what semi planar means here
> 
> LGTM otherwise
> 
> [...]

Done and pushed.

Thanks.

- --phil
-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAlqbLv8ACgkQ+NaxlGp1aC7bbwCeJXTnbTem78t1vxsQet692r/E
0WsAniBv/VtfETvEHViXBS0+SuSup8y+
=Bu9b
-----END PGP SIGNATURE-----