[FFmpeg-devel] [PATCH] swscale: Introduce a helper to identify semi-planar formats

[Michael Niedermayer]

On Fri, Mar 02, 2018 at 03:40:39PM -0800, Philip Langdale wrote:
> This cleans up the ever-more-unreadable list of semi-planar
> exclusions for selecting the planar copy wrapper.
> ---
>  libswscale/swscale_internal.h | 7 +++++++
>  libswscale/swscale_unscaled.c | 7 +------
>  2 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h
> index 0f51df95d7..d3d9da9a34 100644
> --- a/libswscale/swscale_internal.h
> +++ b/libswscale/swscale_internal.h
> @@ -676,6 +676,13 @@ static av_always_inline int isPlanarYUV(enum AVPixelFormat pix_fmt)
>      return ((desc->flags & AV_PIX_FMT_FLAG_PLANAR) && isYUV(pix_fmt));
>  }
>  
> +static av_always_inline int isSemiPlanarYUV(enum AVPixelFormat pix_fmt)

please add a comment unambigously defining what semi planar means here

LGTM otherwise

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180303/158e0c79/attachment.sig>