[FFmpeg-devel] [PATCH] avformat/aiffdec: AIFF fix in case of ANNO
endushka at gmail.com
Wed Jan 10 09:03:00 EET 2018
Yes, the problem found from playing the file AIFF file you can download it
On Tue, Jan 9, 2018 at 10:53 PM, Michael Niedermayer <michael at niedermayer.cc
> On Mon, Jan 08, 2018 at 02:03:40PM +0000, endushka at gmail.com wrote:
> > From: Eduard Sinelnikov <endushka at gmail.com>
> > Apple's AIFF protocol clearly states that each chucnk which is odd sized
> a padding should be added.
> > In the old version of aiffdec adding of padding was done in `get_meta`.
> And in case of unknown chunk name it was done in defalut case.
> > The new version has deleted the padding in default case and added
> padding adding after the switch.
> > But the new version didn't removed the padding adding in the `get_meta`
> function so in some cases padding was added twice which leaded to a bug.
> do you have a testcase you can share that shows the probnlem ?
> or did you find the issue thorugh code review ?
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> It is dangerous to be right in matters on which the established authorities
> are wrong. -- Voltaire
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel