[FFmpeg-devel] [PATCH] avformat/aiffdec: AIFF fix in case of ANNO

Michael Niedermayer michael at niedermayer.cc
Tue Jan 9 22:53:31 EET 2018

On Mon, Jan 08, 2018 at 02:03:40PM +0000, endushka at gmail.com wrote:
> From: Eduard Sinelnikov <endushka at gmail.com>
> Apple's AIFF protocol clearly states that each chucnk which is odd sized a padding should be added.
> In the old version of aiffdec adding of padding was done in `get_meta`. And in case of unknown chunk name it was done in defalut case.
> The new version has deleted the padding in default case and added padding adding after the switch.
> But the new version didn't removed the padding adding in the `get_meta` function so in some cases padding was added twice which leaded to a bug.

do you have a testcase you can share that shows the probnlem ?
or did you find the issue thorugh code review ?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180109/a919641d/attachment.sig>

More information about the ffmpeg-devel mailing list