[FFmpeg-devel] Added - HW accelerated H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Carl Eugen Hoyos]

2017-10-29 16:43 GMT+01:00 Mironov, Mikhail <Mikhail.Mironov at amd.com>:

>> >> > +const enum AVPixelFormat ff_amf_pix_fmts[] = {
>> >> > +    AV_PIX_FMT_NV12,
>> >>
>> >> > +    AV_PIX_FMT_BGRA,
>> >> > +    AV_PIX_FMT_ARGB,
>> >> > +    AV_PIX_FMT_RGBA,
>> >>
>> >> This is wrong, your encoders do not convert transparency information,
>> >> there are 32 rgb formats without alpha channel.
>>
>> > In addition, the encoder has built-in shader-based color converter. It
>> > can accept BGRA and RGBA formats and convert them into NV12
>>
>> Yes, I understood.
>>
>> > dropping alpha channel.
>>
>> Which is why using AV_PIX_FMT_BGRA is wrong, use AV_PIX_FMT_BGR0
>> (and friends).

> Got it, will do. This is my first contribution to FFmpeg. Should I resubmit with
> this change or wait for some time for more comments and resubmit all-together?

While my comment does not justify a new submission,
Mark's clearly does.
(There was more than one sentence in his review.)

Please cut your quotes, Carl Eugen