[FFmpeg-devel] Added - HW accelerated H.264 and HEVC encoding for AMD GPUs based on AMF SDK

[Mironov, Mikhail]

> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Carl Eugen Hoyos
> Sent: October 29, 2017 11:00 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] Added - HW accelerated H.264 and HEVC
> encoding for AMD GPUs based on AMF SDK
> 
> 2017-10-29 15:54 GMT+01:00 Mironov, Mikhail
> <Mikhail.Mironov at amd.com>:
> >> -----Original Message-----
> >> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On
> Behalf
> >> Of Carl Eugen Hoyos
> >> Sent: October 28, 2017 3:19 PM
> >> To: FFmpeg development discussions and patches <ffmpeg-
> >> devel at ffmpeg.org>
> >> Subject: Re: [FFmpeg-devel] Added - HW accelerated H.264 and HEVC
> >> encoding for AMD GPUs based on AMF SDK
> >>
> >> 2017-10-27 20:09 GMT+02:00 mmironov <mikhail.mironov at amd.com>:
> >> > +const enum AVPixelFormat ff_amf_pix_fmts[] = {
> >> > +    AV_PIX_FMT_NV12,
> >>
> >> > +    AV_PIX_FMT_BGRA,
> >> > +    AV_PIX_FMT_ARGB,
> >> > +    AV_PIX_FMT_RGBA,
> >>
> >> This is wrong, your encoders do not convert transparency information,
> >> there are 32 rgb formats without alpha channel.
> 
> > In addition, the encoder has built-in shader-based color converter. It
> > can accept BGRA and RGBA formats and convert them into NV12
> 
> Yes, I understood.
> 
> > dropping alpha channel.
> 
> Which is why using AV_PIX_FMT_BGRA is wrong, use AV_PIX_FMT_BGR0
> (and friends).
> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Got it, will do. This is my first contribution to FFmpeg. Should I resubmit with this change or wait for some time for more comments and resubmit all-together?
Mikhail