[FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

Moritz Barsnick barsnick at gmx.net
Fri Sep 2 15:15:45 EEST 2016


On Fri, Sep 02, 2016 at 14:10:41 +0200, Moritz Barsnick wrote:
> > +    if ((ret = update_fontsize(ctx))) {
> You were meaning to write
>        if (ret = update_fontsize(ctx)) {
> or
>        if ((ret = update_fontsize(ctx)) < 0) {
> ?? (Too many brackets the way you did it.)

Sorry, probably makes sense, equal to
         if ((ret = update_fontsize(ctx)) != 0) {

I'm still not *really* sure whether the second set of brackets is
required to have "if" check the assigned ret (I thought not). I'll let
someone else judge.

Moritz


More information about the ffmpeg-devel mailing list