[FFmpeg-devel] [PATCH] Allow client to enable/disable openh264 load balancing.

Gregory J Wolfe gregory.wolfe at kodakalaris.com
Wed Nov 30 18:44:40 EET 2016


> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On
> Behalf Of Moritz Barsnick
> Sent: Tuesday, November 29, 2016 7:15 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] Allow client to enable/disable
> openh264 load balancing.
> 
> On Mon, Nov 28, 2016 at 16:29:01 -0500, Gregory J. Wolfe wrote:
> > +#if OPENH264_VER_AT_LEAST(1, 6)
> > +    { "load_balancing", "enable/disable load balancing",
> OFFSET(load_balancing), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, VE },
> > +#endif
> 
> This could use a documentation update.

Not sure exactly what you mean by "documentation update".  Some
comments in the code, or more verbosity than "enable/disable load
balancing"?  Please elaborate.

> 
> And since documentation isn't built conditionally, the option could be
> made available unconditionally, and this:
> 
> > +#if OPENH264_VER_AT_LEAST(1, 6)
> > +    param.bUseLoadBalancing          = s->load_balancing;
> > +#endif
> 
> be made to print a warning in an #else .. #endif case. (Perhaps make
> the AV_OPT_TYPE_BOOL option default to -1 in order to detect
> whether it
> was set.)

WRT "default to -1", original intent was to have the default value match
the libopenh264 internal default value.  What should happen if the value
is not set?

> 
> Just suggesting,
> Moritz

More than happy to enhance this patch, waiting for clarification.

Greg W.


More information about the ffmpeg-devel mailing list