[FFmpeg-devel] [PATCH] Allow client to enable/disable openh264 load balancing.

[Moritz Barsnick]

On Mon, Nov 28, 2016 at 16:29:01 -0500, Gregory J. Wolfe wrote:
> +#if OPENH264_VER_AT_LEAST(1, 6)
> +    { "load_balancing", "enable/disable load balancing", OFFSET(load_balancing), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, VE },
> +#endif

This could use a documentation update.

And since documentation isn't built conditionally, the option could be
made available unconditionally, and this:

> +#if OPENH264_VER_AT_LEAST(1, 6)
> +    param.bUseLoadBalancing          = s->load_balancing;
> +#endif

be made to print a warning in an #else .. #endif case. (Perhaps make
the AV_OPT_TYPE_BOOL option default to -1 in order to detect whether it
was set.)

Just suggesting,
Moritz