[FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

Mats Peterson matsp888 at yahoo.com
Sat Feb 27 21:53:33 CET 2016


On 02/27/2016 09:33 PM, Michael Niedermayer wrote:
> On Sat, Feb 27, 2016 at 08:42:25PM +0100, Reimar Döffinger wrote:
>> On Sat, Feb 27, 2016 at 07:51:41PM +0100, Michael Niedermayer wrote:
>>> should rawvideo AVPackets palette use data[] or sidedata, honestly i
>>> do not know, but i dont think it makes a big difference
>>> even supporting both, likely only adds 3-5 lines of code or so
>>> its more a philosophical question
>>
>> Not sure how much was in response to my complaints, but
>
> i dont know either, i was just writing some kind of summary ...
>
>
>> if this parts was I think that misses my point, as I
>> agree that it doesn't matter which.
>> What matters though is:
>> The AVI demuxer creates AVPackets with palette in side data,
>> and the AVI muxer supports ONLY palette appended in the data.
>> How to fix it might be philosophical, but I think it's not
>> philosophical and fairly clear that that's just broken.
>
> yes, though rawvideo stream copy is a bit tricky, especially when
> its not the same container.
> avi<->mov have different stride align requirements for example.

Yes, I mentioned that before, regarding the stride differences. One 
question: For stream copying, the packets will travel unaltered from the 
demuxer to the muxer including the side data, right? Sorry if it sounds 
idiotic.

Mats



More information about the ffmpeg-devel mailing list