[FFmpeg-devel] [PATCH 1/2] lavf/avienc: Simplify palette handling

Michael Niedermayer michael at niedermayer.cc
Sat Feb 27 21:33:19 CET 2016


On Sat, Feb 27, 2016 at 08:42:25PM +0100, Reimar Döffinger wrote:
> On Sat, Feb 27, 2016 at 07:51:41PM +0100, Michael Niedermayer wrote:
> > should rawvideo AVPackets palette use data[] or sidedata, honestly i
> > do not know, but i dont think it makes a big difference
> > even supporting both, likely only adds 3-5 lines of code or so
> > its more a philosophical question
> 
> Not sure how much was in response to my complaints, but

i dont know either, i was just writing some kind of summary ...


> if this parts was I think that misses my point, as I
> agree that it doesn't matter which.
> What matters though is:
> The AVI demuxer creates AVPackets with palette in side data,
> and the AVI muxer supports ONLY palette appended in the data.
> How to fix it might be philosophical, but I think it's not
> philosophical and fairly clear that that's just broken.

yes, though rawvideo stream copy is a bit tricky, especially when
its not the same container.
avi<->mov have different stride align requirements for example.
We currently correct that in the muxer
If we similarly also handle side data and extradata palettes in
the muxer (via shared code ideally) then any input would work
not sure this is the best solution

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160227/724e46e7/attachment.sig>


More information about the ffmpeg-devel mailing list