[FFmpeg-devel] [PATCH] Allow client to enable/disable openh264 load balancing.

Michael Niedermayer michael at niedermayer.cc
Wed Dec 14 20:20:00 EET 2016


On Wed, Dec 14, 2016 at 03:11:45PM +0000, Gregory J Wolfe wrote:
> > -----Original Message-----
> > From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On
> > Behalf Of Michael Niedermayer
> > Sent: Tuesday, December 13, 2016 2:28 PM
> > To: FFmpeg development discussions and patches <ffmpeg-
> > devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH] Allow client to enable/disable
> > openh264 load balancing.
> > 
> > On Thu, Dec 01, 2016 at 03:52:55PM -0500, Gregory J. Wolfe wrote:
> > > The libopenh264 library allows the client to enable or disable
> > > load balancing when running multi-threaded.  When enabled, the
> > > slice sizes are dynamically adjusted in order to use the
> > > multiple threads more efficiently.  However, this can also lead
> > > to valid but slightly different results from run to run.
> > > Disabling load balancing prevents dynamic slice adjustment and
> > > yields repeatable results when running multi-threaded, which can
> > > be important when running test cases.
> > >
> > > Signed-off-by: Gregory J. Wolfe <gregory.wolfe at kodakalaris.com>
> > > ---
> > >  libavcodec/libopenh264enc.c | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > 
> > Commit messages should start with the part that is changes like
> > libavcodec/libopenh264enc: ...
> > 
> > please see the developer docs, if you haven't read them
> 
> Sorry about that.  Before submitting I carefully reviewed the
> "Submitting patches" and "patch submission checklist" sections,
> but neglected to also go back and review the "Development
> Policy" section where it talks about "area changed: ..." in the
> commit message.  Will fix and resubmit.
> 

> Suggestion:  Add to the patch checklist section a reference back
> to this information (to remind infrequent patch submitters like me
> who forget stuff from the last time we submitted a patch).

you can send a patch to improve the patch submission checklist
its in doc/developer.texi

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161214/19fa4e2b/attachment.sig>


More information about the ffmpeg-devel mailing list