[FFmpeg-devel] [PATCH] Allow client to enable/disable openh264 load balancing.

Gregory J Wolfe gregory.wolfe at kodakalaris.com
Wed Dec 14 17:11:45 EET 2016


> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On
> Behalf Of Michael Niedermayer
> Sent: Tuesday, December 13, 2016 2:28 PM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] Allow client to enable/disable
> openh264 load balancing.
> 
> On Thu, Dec 01, 2016 at 03:52:55PM -0500, Gregory J. Wolfe wrote:
> > The libopenh264 library allows the client to enable or disable
> > load balancing when running multi-threaded.  When enabled, the
> > slice sizes are dynamically adjusted in order to use the
> > multiple threads more efficiently.  However, this can also lead
> > to valid but slightly different results from run to run.
> > Disabling load balancing prevents dynamic slice adjustment and
> > yields repeatable results when running multi-threaded, which can
> > be important when running test cases.
> >
> > Signed-off-by: Gregory J. Wolfe <gregory.wolfe at kodakalaris.com>
> > ---
> >  libavcodec/libopenh264enc.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> 
> Commit messages should start with the part that is changes like
> libavcodec/libopenh264enc: ...
> 
> please see the developer docs, if you haven't read them

Sorry about that.  Before submitting I carefully reviewed the
"Submitting patches" and "patch submission checklist" sections,
but neglected to also go back and review the "Development
Policy" section where it talks about "area changed: ..." in the
commit message.  Will fix and resubmit.

Suggestion:  Add to the patch checklist section a reference back
to this information (to remind infrequent patch submitters like me
who forget stuff from the last time we submitted a patch).

Greg W.

> 
> thx
> 
> [...]
> --
> Michael     GnuPG fingerprint:
> 9FF2128B147EF6730BADF133611EC787040B0FAB


More information about the ffmpeg-devel mailing list