[FFmpeg-devel] [PATCH] news: add thank you note for telepoint/mediahub

compn tempn at mi.rr.com
Tue Oct 13 15:37:46 CEST 2015


On Tue, 13 Oct 2015 09:18:35 -0400
Ganesh Ajjanagadde <gajjanag at mit.edu> wrote:

> On Tue, Oct 13, 2015 at 9:13 AM, compn <tempn at mi.rr.com> wrote:
> > On Mon, 12 Oct 2015 15:10:22 -0700
> > "Reynaldo H. Verdejo Pinochet" <reynaldo at osg.samsung.com> wrote:
> >
> >> Signed-off-by: Reynaldo H. Verdejo Pinochet
> >> <reynaldo at osg.samsung.com> ---
> >>  src/index | 33 +++++++++++++++++++++++++++++++++
> >>  1 file changed, 33 insertions(+)
> >
> > thanks
> >
> > applied.
> 
> Was the grammar change I pointed out incorporated? What about the
> second suggestion?

you can check on ffmpeg.org (it updated as soon as i committed).

"on their own" -> "in their own" was fixed. thank you.

"for their support" -> "for your support" was not.

just my personal choice, as now the sentence kind of reads as a general
"everyone should thank telepoint/mediahub for this donation" instead of
a "we thank telepoint/mediahub for this donation". more of a community
thank you? i dunno. maybe it should be "thanks TO telepoint and ..."
instead.

if i was going to fix something else i'd probably change this as well:
"donated a dedicated server with free of charge internet connectivity."
to "donated a dedicated server and bandwidth."

i am a native english speaker , but years of helping non-native english
speakers has warped my comprehension. so now if i think the sentence
conveys the required information, i will just leave it alone. :)

otherwise hours and hours get spent on spelling and grammar and it
drains motivation to work on other things.

-compn


More information about the ffmpeg-devel mailing list