[FFmpeg-devel] [RFC][PATCH] libwebp: combine libwebp_anim and libwebp encoders into one

Michael Niedermayer michaelni at gmx.at
Mon May 25 00:49:21 CEST 2015

On Sun, May 24, 2015 at 06:39:05PM -0300, James Almer wrote:
> On 24/05/15 5:59 PM, Michael Niedermayer wrote:
> > On Sun, May 24, 2015 at 04:22:42PM -0300, James Almer wrote:
> >> Use either the WebPEncoder or WebPAnimEncoder APIs depending on availability
> >> of the latter.
> >>
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> >> ---
> >> This is an RFC because the resulting encoder will use one of the two APIs, which
> >> is a change from the current behavior of having one encoder for each API.
> >> The new encoder was added only two days ago so removing it shouldn't be an issue.
> >> Basically, is there any benefit from using the native lavf muxer over letting
> >> WebPAnimEncoder do the entire process to justify having two encoders?
> >>
> >> The resulting ifdeffery is minimal now that the webp muxer can act as a raw muxer
> >> cleanly, so the only concern is the above. We can deal with cosmetics later, but
> >> the functional change needs to be done asap least we want to deal with deprecation
> >> nonsense if the new encoder makes it into a release.
> > 
> > They are 2 different encoders, the old is partly implemented in
> > FFmpeg, the new does all steps in an external lib
> > The 2 variants work differently
> > command lines for the old encoder do NOT work with WebPAnimEncoder,
> > at least not with the current implementation we have
> My intention was to keep it all as a single encoder, using one of the two APIs depending
> on availability. If the AVOptions have different results on them then i guess it's not
> really feasible after all. So patch dropped.

I dont know if its (im)possible with the new API to support the
stuff, just that it is not supported with the current
wraper/implementation we have


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150525/d2be0bc2/attachment.asc>

More information about the ffmpeg-devel mailing list