[FFmpeg-devel] [RFC][PATCH] libwebp: combine libwebp_anim and libwebp encoders into one

[Michael Niedermayer]

On Sun, May 24, 2015 at 06:39:05PM -0300, James Almer wrote:
> On 24/05/15 5:59 PM, Michael Niedermayer wrote:
> > On Sun, May 24, 2015 at 04:22:42PM -0300, James Almer wrote:
[...]
> > 
> > try it yourself
> > ./ffmpeg -i matrixbench_mpeg2.mpg -cr_threshold 10000 -cr_size 16 -t 10 -loop 2 -vcodec libwebp test.webp
> > 
> > works with the old encoder but after this patch produces a video
> > that is a flickering checkerboard
> 
> This happens when the WebPAnimEncoder API is used alongside one or two of those -cr_
> options. Unrelated to this patch, but as i said above a good argument against it.
> 
> It should be fixed, for that matter. CCing Urvang Joshi.
> 
> > 
> > Also libwebp lacks a maintainer in MAINTAINERs
> > anyone volunteers ?
> 
> libwebpenc_animencoder.c should be maintained by the person that wrote/submitted it.

Urvang
do you agree to be the official maintainer for the file ?
if so please send a patch which adds you to the MAINTAINERs file


> 
> > 
> > I might be willing to maintain it when the 2 encoders can be tested
> > without the need to build ffmpeg twice (they can be in one .c file for
> > that or in multiple of course),
> 
> I'm not sure what you mean. The two encoders can be tested without having to build
> ffmpeg twice, assuming you have a new enough libwebp/mux installed. They are currently
> independent, and you can use one or the other with -c:v or such.

yes, i mentioned it because the patch would have changed that
i was a bit afraid that i could loose the ability to easily test
both codepathes
it wouldnt matter if one codepath could be dropped but IIUC the
libwebpenc_animencoder needs git master of libwebp so few people
will have support for it


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150525/0c0a5a15/attachment.asc>