[FFmpeg-devel] [libav-devel] [PATCH 2/2] lavf: move internal fields from public to internal context

Bálint Réczey balint at balintreczey.hu
Thu Mar 5 10:15:51 CET 2015


Hi,

2015-03-05 0:02 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:
> On 04.03.2015 23:13, Luca Barbato wrote:
>>
>> On 04/03/15 21:49, Andreas Cadhalpun wrote:
>>>
>>> So what do you think about resurrecting this patch (add avformat_flush)?
>>
>>
>> I see no patch about it, my email client chewed it?
>
>
> It has been a while ago [1]. It just adds a public API for
> ff_read_frame_flush.
>
>>> It seems to have only stalled on the associated documentation and the
>>> XBMC developers are apparently not the only ones who would find it
>>> useful.
>>
>>
>> The function is useful if somebody wants to implement some custom seek
>> and in order to do that probably is using some of the fields being
>> hidden so I'm not sure just exposing that function would do anything
>> good for that use case.
>>
>> I'd rather check with the XBMC (I guess now the name is Kodi, let's try
>> to move to use the new name) people why they need it and if the problem
>> they have with the seeking functions can't be solved otherwise.
>
>
> To me it seems that this is the only internal API they need, but asking
> can't hurt. So CC'ing the Debian XBMC/Kodi maintainer.
I would welcome the resurrection of avformat flush. This is the only
internal API used by XBMC/Kodi indeed.
To work wih the public API I carry a patch [2] reimplementing the
function in Kodi, but I would prefer using it as part of the public
API.

CC-ing Joakim who started using the function in XBMC and FernetMenta
who also worked on this part of the code.

First related commit I found was tnis one:

commit ba44e48ca680512dad789dda504020bf59570986
Author: elupus <elupus at svn>
Date:   Mon Feb 1 04:41:03 2010 +0000

    changed: use lavf's proper method to flush data after input stream seek
    changed: make sure we flush demuxer on dvd seeks

    git-svn-id:
https://xbmc.svn.sourceforge.net/svnroot/xbmc/trunk@27348
568bbfeb-2a22-0410-94d2-cc84cf5bfa90


Cheers,
Balint

>
> Best regards,
> Andreas
>
>
> 1: https://ffmpeg.org/pipermail/ffmpeg-devel/2014-September/163635.html
[2] https://anonscm.debian.org/cgit/pkg-multimedia/kodi.git/commit/?id=dc8ea7b87cf03f034bd7b07cfa246f1760b30f31


More information about the ffmpeg-devel mailing list