[FFmpeg-devel] [PATCH] mov: write colr by default

[Robert Krüger]

On Wed, Mar 4, 2015 at 11:05 AM, Michael Niedermayer <michaelni at gmx.at>
wrote:

> On Wed, Mar 04, 2015 at 10:22:26AM +0100, Robert Krüger wrote:
> > On Tue, Mar 3, 2015 at 9:27 PM, Michael Niedermayer <michaelni at gmx.at>
> > wrote:
> >
> > > On Tue, Mar 03, 2015 at 09:24:17PM +0100, Robert Krüger wrote:
> > > > On Tue, Mar 3, 2015 at 7:23 PM, Michael Niedermayer <
> michaelni at gmx.at>
> > > > wrote:
> > > >
> > > > > On Tue, Mar 03, 2015 at 06:17:22PM +0100, Robert Krüger wrote:
> > > > >
> > > > > > This is based on an earlier patch by Derek
> > > > >
> > > > > please mention this in the commit message
> > > > >
> > > >
> > > > OK, I will change that
> > > >
> > > >
> > > > >
> > > > >
> > > > > > that never went in because it
> > > > > > was argumented earlier that api breakage is not acceptable.
> However,
> > > that
> > > > > > was more or less relaxed after Michael noted that the replaced
> flag
> > > had
> > > > > > never been part of a release and since a number of people seem to
> > > agree,
> > > > > > this is the better default, I am submitting this patch now, to
> have
> > > it in
> > > > > > before the upcoming release.
> > > > > >
> > > > >
> > > > > > Let me know if that will be accepted and I will modify the
> respective
> > > > > fate
> > > > > > tests as well.
> > > > >
> > > > > have you tested the generated mov and mp4 files with some common
> > > > > software packages ?
> > > > >
> > > > > checking random files on my disk it seems more than half the mov
> > > > > files contain a colr atom but i found just a single mp4 with a colr
> > > > > atom, so especially testing the compatibility of the mp4 files
> would
> > > > > be optimal before this is changed
> > > > >
> > > > >
> > > > OK, I will do some tests with VLC, Quicktime, Final Cut, Final Cut X,
> > > > Premiere and After Effects and maybe something else I find.
> > >
> > > thanks
> > >
> > >
> > I tried an mp4 file with a colr atom with VLC, Quicktime, Final Cut X,
> > Compressor, Premiere, After Effects and Adobe Media Encoder. None of
> those
> > had any problems with the file and colors looked normal too.
>
> ok then please submit a patch that also updates fate
>
>
here it is.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mov_write_colr_by_default.patch
Type: application/octet-stream
Size: 30479 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150304/86783bfa/attachment.obj>