[FFmpeg-devel] [PATCH] mov: write colr by default

[Michael Niedermayer]

On Wed, Mar 04, 2015 at 10:22:26AM +0100, Robert Krüger wrote:
> On Tue, Mar 3, 2015 at 9:27 PM, Michael Niedermayer <michaelni at gmx.at>
> wrote:
> 
> > On Tue, Mar 03, 2015 at 09:24:17PM +0100, Robert Krüger wrote:
> > > On Tue, Mar 3, 2015 at 7:23 PM, Michael Niedermayer <michaelni at gmx.at>
> > > wrote:
> > >
> > > > On Tue, Mar 03, 2015 at 06:17:22PM +0100, Robert Krüger wrote:
> > > >
> > > > > This is based on an earlier patch by Derek
> > > >
> > > > please mention this in the commit message
> > > >
> > >
> > > OK, I will change that
> > >
> > >
> > > >
> > > >
> > > > > that never went in because it
> > > > > was argumented earlier that api breakage is not acceptable. However,
> > that
> > > > > was more or less relaxed after Michael noted that the replaced flag
> > had
> > > > > never been part of a release and since a number of people seem to
> > agree,
> > > > > this is the better default, I am submitting this patch now, to have
> > it in
> > > > > before the upcoming release.
> > > > >
> > > >
> > > > > Let me know if that will be accepted and I will modify the respective
> > > > fate
> > > > > tests as well.
> > > >
> > > > have you tested the generated mov and mp4 files with some common
> > > > software packages ?
> > > >
> > > > checking random files on my disk it seems more than half the mov
> > > > files contain a colr atom but i found just a single mp4 with a colr
> > > > atom, so especially testing the compatibility of the mp4 files would
> > > > be optimal before this is changed
> > > >
> > > >
> > > OK, I will do some tests with VLC, Quicktime, Final Cut, Final Cut X,
> > > Premiere and After Effects and maybe something else I find.
> >
> > thanks
> >
> >
> I tried an mp4 file with a colr atom with VLC, Quicktime, Final Cut X,
> Compressor, Premiere, After Effects and Adobe Media Encoder. None of those
> had any problems with the file and colors looked normal too.

ok then please submit a patch that also updates fate

[...
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150304/3273dadb/attachment.asc>