[FFmpeg-devel] [PATCH 1/4] mpeg4: use a self-explanatory #define MAX_NVOP_SIZE

[Michael Niedermayer]

On Fri, Apr 03, 2015 at 08:37:29PM +0200, Andreas Cadhalpun wrote:
> On 03.04.2015 20:20, Michael Niedermayer wrote:
> > On Fri, Apr 03, 2015 at 07:14:16PM +0200, Andreas Cadhalpun wrote:
> >> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> >> ---
> >>  libavcodec/h263dec.c    | 2 +-
> >>  libavcodec/mpeg4video.h | 3 +++
> >>  2 files changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c
> >> index a1981a3..0dde897 100644
> >> --- a/libavcodec/h263dec.c
> >> +++ b/libavcodec/h263dec.c
> >> @@ -459,7 +459,7 @@ retry:
> >>          }
> >>      }
> >>  
> >> -    if (s->bitstream_buffer_size && (s->divx_packed || buf_size < 20)) // divx 5.01+/xvid frame reorder
> >> +    if (s->bitstream_buffer_size && (s->divx_packed || buf_size < MAX_NVOP_SIZE)) // divx 5.01+/xvid frame reorder
> > 
> > its nitpicking but shouldnt it be <= if the constant is a maximum ?
> 
> I didn't want to change the code, but '<=' would work as well, because
> the constant is rather arbitrary. Feel free to change this, when committing.

changed
applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150404/7e3cff70/attachment.asc>