[FFmpeg-devel] [PATCH 1/4] mpeg4: use a self-explanatory #define MAX_NVOP_SIZE

[Andreas Cadhalpun]

On 03.04.2015 20:20, Michael Niedermayer wrote:
> On Fri, Apr 03, 2015 at 07:14:16PM +0200, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> ---
>>  libavcodec/h263dec.c    | 2 +-
>>  libavcodec/mpeg4video.h | 3 +++
>>  2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c
>> index a1981a3..0dde897 100644
>> --- a/libavcodec/h263dec.c
>> +++ b/libavcodec/h263dec.c
>> @@ -459,7 +459,7 @@ retry:
>>          }
>>      }
>>  
>> -    if (s->bitstream_buffer_size && (s->divx_packed || buf_size < 20)) // divx 5.01+/xvid frame reorder
>> +    if (s->bitstream_buffer_size && (s->divx_packed || buf_size < MAX_NVOP_SIZE)) // divx 5.01+/xvid frame reorder
> 
> its nitpicking but shouldnt it be <= if the constant is a maximum ?

I didn't want to change the code, but '<=' would work as well, because
the constant is rather arbitrary. Feel free to change this, when committing.

Best regards,
Andreas