[FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

[Clément Bœsch]

On Tue, Jun 17, 2014 at 11:08:15PM +0000, Carl Eugen Hoyos wrote:
> Clément Bœsch <u <at> pkh.me> writes:
> 
> > +enabled libx264           && require_pkg_config 
> > "x264 >= 0.118" "stdint.h x264.h" x264_encoder_encode
> 
> Since this needlessly breaks scripts, I am against this.
> 

It's not needlessly since it fixes builds when libx264 is built against
external libs to the least, without a hack of trying to guess what library
could be needed. It simplifies the creation of static builds. And also it
simplifies specifying a custom x264 build. Finally, it's the official
supported way of linking to x264.

It indeed might break some scripts that used to workaround the previous
issues with --extra-{c,ld}flags. But that's the reason we are documenting
the change, and also displays a very obvious error in case it fails.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140618/3999653e/attachment.asc>