[FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

[Hendrik Leppkes]

On Tue, Jun 17, 2014 at 6:21 PM, Timothy Gu <timothygu99 at gmail.com> wrote:
> On Tue, Jun 17, 2014 at 4:08 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>> Clément Bœsch <u <at> pkh.me> writes:
>>
>>> +enabled libx264           && require_pkg_config
>>> "x264 >= 0.118" "stdint.h x264.h" x264_encoder_encode
>>
>> Since this needlessly breaks scripts, I am against this.
>
> What kind of scripts? pkg-config is the de facto standard for finding
> libraries, and it does a good job doing that too. This change only
> encourages the use of industry standards, and it does not "break
> scripts" on properly set-up systems.
>

+1

pkg-config is the proper way to handle library deps if they expose a
proper script for it.