[FFmpeg-devel] [PATCH] ffmpeg: add otsoffset option

[Michael Niedermayer]

On Tue, Jan 28, 2014 at 01:33:42AM +0100, Stefano Sabatini wrote:
> On date Tuesday 2014-01-28 01:24:34 +0100, Michael Niedermayer encoded:
> > On Mon, Jan 27, 2014 at 07:53:33PM +0100, Stefano Sabatini wrote:
> > > On date Thursday 2014-01-23 23:00:25 +0100, Michael Niedermayer encoded:
> > > > On Thu, Jan 23, 2014 at 06:47:36PM +0100, Stefano Sabatini wrote:
> > > > > This option is useful to add a given offset to the output. Since it works
> > > > > at the muxing level, it doesn't need transcoding.
> > > > > 
> > > > > This is slightly more convenient to use than -itsoffset, since it only
> > > > > works with -copyts, while the new option allows to set the absolute
> > > > > offset when -copyts is not selected.
> > > > 
> > > 
> > > > if the option works at the muxer level then implemegting it in
> > > > libavformat would have the advantage that it would be available to
> > > > all libavformtat using applications and not just ffmpeg.c
> > > 
> > > Done like that, feel free to nitpick about names.
> > > 
> > 
> 
> > > Note: I'm not sure about the av_format_get_output_ts_offset()
> > > accessors, should I keep them or let the user set them via the
> > > AVOption API?
> > 
> > whichever you prefer
> 
> I don't want to add an API which is not strictly required (and the

agree


> other AVFormatContext accessors seem to be used only for setting
> binary content), but I'm not sure about that.

the accessors make most sense for things that need to be accessed
often as AVOptions currently have to do string matching to find a
entry and that isnt the fastest way to access things.
Also the accessors might be felt to be prettier when used from C code
to set / get fields than using a API thats based on a string representing
the field to be set ("otsoffset")


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140128/9e7b3bd1/attachment.asc>