[FFmpeg-devel] [PATCH] ffmpeg: add otsoffset option

[Stefano Sabatini]

On date Tuesday 2014-01-28 01:24:34 +0100, Michael Niedermayer encoded:
> On Mon, Jan 27, 2014 at 07:53:33PM +0100, Stefano Sabatini wrote:
> > On date Thursday 2014-01-23 23:00:25 +0100, Michael Niedermayer encoded:
> > > On Thu, Jan 23, 2014 at 06:47:36PM +0100, Stefano Sabatini wrote:
> > > > This option is useful to add a given offset to the output. Since it works
> > > > at the muxing level, it doesn't need transcoding.
> > > > 
> > > > This is slightly more convenient to use than -itsoffset, since it only
> > > > works with -copyts, while the new option allows to set the absolute
> > > > offset when -copyts is not selected.
> > > 
> > 
> > > if the option works at the muxer level then implemegting it in
> > > libavformat would have the advantage that it would be available to
> > > all libavformtat using applications and not just ffmpeg.c
> > 
> > Done like that, feel free to nitpick about names.
> > 
> 

> > Note: I'm not sure about the av_format_get_output_ts_offset()
> > accessors, should I keep them or let the user set them via the
> > AVOption API?
> 
> whichever you prefer

I don't want to add an API which is not strictly required (and the
other AVFormatContext accessors seem to be used only for setting
binary content), but I'm not sure about that.

> 
> patch LGTM
> 
> a fate test might also be a good idea
> 
> thanks
-- 
FFmpeg = Formidable Faithful Multimedia Political Earthshaking Geek