[FFmpeg-devel] [PATCH 2/2] lavd: add lavfi dependencies for test programs.

[Michael Niedermayer]

On Thu, Feb 06, 2014 at 07:52:14PM +0100, Nicolas George wrote:
> > On Thu, Feb 06, 2014 at 01:23:54PM +0100, Lukasz M wrote:
> > > I'm not a linker guru, but maybe these new deps should be applied to test
> > > programs, not library.
> 
> In fact, I had not realized that FFLIBS was used to link the shared
> libraries and not only for the test programs.
> 
> L'octidi 18 pluviôse, an CCXXII, Michael Niedermayer a écrit :
> > yes, and after sleeping over it theres actually a simple solution
> > 
> > just link the test program against all installed libs, this would be
> > very close to what exact dependancies would result in for this
> > most of the time i think
> 
> I believe that would work, and having useless deps for tests programs is not
> a problem. On the other hand, that would mean that a lavu test program can
> not be run unless all the other libs have been built. Imagine someone
> changing lavu/error.h and building error-test: they must wait for all lavc
> and lavf to rebuild. Not very comfortable.
> 
> I see actually a simpler solution for the case at hand (the uncoded frame
> test program): since this is not a really simple test
> program, it can go into tools/ or tests/, and be build with:
> 
> PROGS += tools/uncoded_frame
> 
> That would have the additional advantage of allowing to use lavfi, that
> would make it simpler and more powerful.
> 
> Would this be ok?

it looks ok, and i definitly start feeling bad for always finding
some issue that ends up causing you lots of additional work


> Any preference between tools and tests?

i see good arguments for both, so i dont know, pick what you prefer


> 
> Other test programs only test a very small part of the library and therefore
> do not suffer from the problem.
> 
> Regards,
> 
> -- 
>   Nicolas George



> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140206/409b96d0/attachment.asc>