[FFmpeg-devel] [PATCH 2/2] lavd: add lavfi dependencies for test programs.

Nicolas George george at nsup.org
Thu Feb 6 19:52:14 CET 2014


> On Thu, Feb 06, 2014 at 01:23:54PM +0100, Lukasz M wrote:
> > I'm not a linker guru, but maybe these new deps should be applied to test
> > programs, not library.

In fact, I had not realized that FFLIBS was used to link the shared
libraries and not only for the test programs.

L'octidi 18 pluviôse, an CCXXII, Michael Niedermayer a écrit :
> yes, and after sleeping over it theres actually a simple solution
> 
> just link the test program against all installed libs, this would be
> very close to what exact dependancies would result in for this
> most of the time i think

I believe that would work, and having useless deps for tests programs is not
a problem. On the other hand, that would mean that a lavu test program can
not be run unless all the other libs have been built. Imagine someone
changing lavu/error.h and building error-test: they must wait for all lavc
and lavf to rebuild. Not very comfortable.

I see actually a simpler solution for the case at hand (the uncoded frame
test program): since this is not a really simple test
program, it can go into tools/ or tests/, and be build with:

PROGS += tools/uncoded_frame

That would have the additional advantage of allowing to use lavfi, that
would make it simpler and more powerful.

Would this be ok? Any preference between tools and tests?

Other test programs only test a very small part of the library and therefore
do not suffer from the problem.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140206/5397b27b/attachment.asc>


More information about the ffmpeg-devel mailing list