[FFmpeg-devel] [PATCH] lavd/alsa-audio-common: dont crash while closing not opened device

Nicolas George george at nsup.org
Mon Dec 15 14:05:18 CET 2014


Le quintidi 25 frimaire, an CCXXIII, Lukasz Marek a écrit :
> for example
> ffmpeg -f alsa -i  aaaa -f alsa aaa
> would crash if ffmpeg tried to close alsa after open fail. It doesn't so it
> doesn't occur.
> 
> This commit also make safe to call close function twice on the same context

In that case, I am not sure if that is such a good idea. Applications should
not be calling av_write_trailer() on unopened contexts, it is not a benign
operation like free(). But I will not insist on it.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141215/39b0e14a/attachment.asc>


More information about the ffmpeg-devel mailing list