[FFmpeg-devel] [PATCH] lavd/alsa-audio-common: dont crash while closing not opened device

Lukasz Marek lukasz.m.luki2 at gmail.com
Mon Dec 15 14:02:35 CET 2014


On 15 December 2014 at 13:05, Nicolas George <george at nsup.org> wrote:
>
> Le quintidi 25 frimaire, an CCXXIII, Lukasz Marek a écrit :
> > snd_pcm_close() doesn't handle NULL correctly.
> >
> > Signed-off-by: Lukasz Marek <lukasz.m.luki2 at gmail.com>
> > ---
> >  libavdevice/alsa-audio-common.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
>
> I think it is ok, but can you explain the code path that leads to it?
>

for example
ffmpeg -f alsa -i  aaaa -f alsa aaa
would crash if ffmpeg tried to close alsa after open fail. It doesn't so it
doesn't occur.

This commit also make safe to call close function twice on the same context


More information about the ffmpeg-devel mailing list