[FFmpeg-devel] [PATCH 1/2] matroskaenc: Add CuePoints for subtitle tracks

James Almer jamrial at gmail.com
Fri Sep 20 23:02:34 CEST 2013

On 20/09/13 5:49 PM, Michael Niedermayer wrote:
> On Thu, Sep 19, 2013 at 08:21:16PM -0300, James Almer wrote:
>> On 19/09/13 7:11 PM, Michael Niedermayer wrote:
>>> On Sat, Sep 14, 2013 at 05:59:21AM -0300, James Almer wrote:
>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>> ---
>>>>  libavformat/matroskaenc.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> Do these 2 patches fix/improve playback/seeking with some software?
>>> If so please put this information in the commit message
>>> and also explain how the issue and fix can be reproduced if you
>>> have a testcase
>> I don't know if any software currently reads and uses cues for subtitle tracks, 
>> and considering how new the cueduration element is i doubt any software reads 
>> them either.
>> I'm essentially replicating mkvtoolnix muxing practices with this. Afaik, with 
>> proper demuxer/splitter support, the idea of having a cueduration entry in 
>> subtitle cue points is to improve the display of subtitles right after seeking 
>> to a given point in the stream.
> if you say this matches existing practice then its ok
> first patch applied
> second seems not to apply anymore

The fate test changed after the muxingapp patch from a few days ago.
I'll resubmit it later.


More information about the ffmpeg-devel mailing list